Roles and Activities > Developer Role Set > Design Reviewer > Review the Design
Arrange one review of the design model per iteration in the Elaboration and Construction phases, where you review the work in progress. Then, in the iteration in the Construction phase, where the design model is considered to be more or less complete, you should arrange a detailed review of the design model. You should also arrange one review meeting per iteration in the other phases (Inception and Transition) when the design model is refined.
The participants of the review meetings will ultimately approve the design model. Before that, you will probably have to review the system several times, because results from a review will undoubtedly result in changes to the model.
The design model as a whole must be reviewed to detect glaring problems with layering and responsibility partitioning. The purpose of reviewing the model as a whole is to detect large-scale problems that a more detailed review would miss.
In the Inception phase and early in the Elaboration phase, this review will be focused on the overall structure of the model, with special emphasis on layering and on interfaces. Package and Subsystem dependencies should be examined to ensure loose coupling between packaging elements. The contents of packages and subsystems should be examined to ensure high cohesion within packaging elements. In general, all elements should be examine to ensure that they have clear and appropriate responsibilities, and that their names reflect these responsibilities.
Once at least architectural prototypes have been developed, a more comprehensive review of the design should be conducted. The model should first be reviewed for overall completeness, and then more carefully to discover defects.
Once the structure of the design model is reviewed, the behavior of the model needs to be reviewed. First, make sure that there is no missing behavior by checking to see that all scenarios for the current iteration have been completely covered by use-case realizations. All of the behavior in the relevant use-case sub-flows must be described in the completed use-case realizations.
In cases where the behavior of the system is event-driven, you may have used statechart diagrams to describe the behavior of the use case. Where they exist, statechart diagrams need to be examined to ensure that they describe the correct behavior, see Guidelines: Statechart Diagram for more details.
Next, make sure the behavior of the use-case realization is correctly distributed between model elements in the realizations: make sure the operations are used correctly, that all parameters are passed, and that return values are of the correct type.
Review each Subsystem (and its contents) or Class (if the system is small)
For each model element to which behavior is allocated, the internal design of the model element must be reviewed. For subsystems, this means ensuring that the behavior specified in the interfaces the subsystem realizes has been allocated to one or more contained classes or subsystems. For classes, this means that the description of each operation is sufficient defined so that it may be implemented unambiguously.
On the basis of the design review, look for defects in the Design Guidelines:
Following each review meeting, the results of the meeting must be documented
in a Review Record. In addition, defects must be documented (and eventually
assigned to someone to own and drive to resolution).
Rational Unified Process